Fix npm publish including root-level source files - #292
Open
Swimburger wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The published
cohere-aipackage currently includes both the root-level output files and the compileddist/output, bloating the install size and exposing unintended files to consumers.This PR updates
.npmignoreto exclude source files from the published package, so onlydist/is included.Also added the other entries Fern would normally manage, for completeness. Since
.npmignoreis in.fernignore, this file will need to be maintained manually going forward.Note
Low Risk
Low risk: this only changes npm packaging contents, though it could break consumers if they relied on previously (incorrectly) published files.
Overview
Tightens npm publish behavior by expanding
.npmignoreto exclude additional root-level project files (e.g.,tests,.fern,biome.json,pnpm-lock.yaml,scripts, and test configs) and ensure only intended artifacts likedist/are included in the published package.Reviewed by Cursor Bugbot for commit 6e2f18b. Bugbot is set up for automated code reviews on this repo. Configure here.